Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(logger): isVerbose(), getTimeEntries() #6383

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Oct 24, 2018

Fixes #6313. Unblocks #3745.

@brendankenny
Copy link
Member

for background for others, we decided on just doing isVerbose() (instead of isWarning, isError, etc, or some other getLevel()/isLevel(levelStr)/whatever API) for now since that's the only real need we've had so far and so reimplementing/exposing the log level hierarchy would be more work for no benefit today.

We can always revisit when someone actually needs logger.isError() :)

Opinions on the specific choice we made are welcome, of course :)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish paulirish merged commit 55b96b2 into master Oct 24, 2018
@paulirish paulirish deleted the issue-6313-logger-improvements branch October 24, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants